Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updagrade to solidity v0.4.17 #511

Closed
maraoz opened this issue Oct 24, 2017 · 3 comments
Closed

updagrade to solidity v0.4.17 #511

maraoz opened this issue Oct 24, 2017 · 3 comments
Labels
good first issue Low hanging fruit for new contributors to get involved!

Comments

@maraoz
Copy link
Contributor

maraoz commented Oct 24, 2017

See: https://github.com/ethereum/solidity/releases/tag/v0.4.17

Some things that need to be done:

  • change pragma headers.
  • Replace occurrences of constant with view or pure.
  • add explicit visibility to all functions
@maraoz maraoz added good first issue Low hanging fruit for new contributors to get involved! enhancement labels Oct 24, 2017
@brandongilchrist2
Copy link
Contributor

Can I assume you mean "upgrade to solidity v0.4.17" not v0.4.11?

@maraoz maraoz changed the title updagrade to solidity v0.4.11 updagrade to solidity v0.4.17 Oct 27, 2017
@maraoz
Copy link
Contributor Author

maraoz commented Oct 27, 2017

@brandongilchrist good catch! fixed

@maraoz maraoz mentioned this issue Nov 11, 2017
Closed
@pash7ka pash7ka mentioned this issue Nov 16, 2017
Closed
@pash7ka
Copy link
Contributor

pash7ka commented Nov 16, 2017

I've commited pull request, but CI build fails on "pure"/"view" keywords. Perhaps it uses the old compiler version.

@theethernaut theethernaut mentioned this issue Nov 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maraoz @pash7ka @brandongilchrist2