Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to truffle 4.0.0 and solc 0.4.18 #573

Merged
merged 5 commits into from Nov 22, 2017
Merged

Update to truffle 4.0.0 and solc 0.4.18 #573

merged 5 commits into from Nov 22, 2017

Conversation

theethernaut
Copy link
Contributor

@theethernaut theethernaut commented Nov 21, 2017

Fixes #511.

@theethernaut
Copy link
Contributor Author

All tests are passing but coverage is failing because of #535

@frangio
Copy link
Contributor

frangio commented Nov 22, 2017

We will remove coverage analysis until it's fixed. 😢

@ajsantander can you add a commit removing these lines?
https://github.com/OpenZeppelin/zeppelin-solidity/blob/db5a12cfddeff2e96bb6c3259c7a7b0702444c5d/.travis.yml#L9-L15
This will disable the coverage job in Travis. We can revert that commit later.

had to up the gasLimit in test.sh to avoid an out of gas error when deploying the scripts
This is required to update to truffle 4 and solc 0.4.18, see PR #573
@theethernaut theethernaut merged commit 0bcf0a2 into OpenZeppelin:master Nov 22, 2017
ProphetDaniel pushed a commit to classicdelta/Smart-Contracts that referenced this pull request Mar 9, 2018
This is required to update to truffle 4 and solc 0.4.18, see PR OpenZeppelin#573
ProphetDaniel pushed a commit to classicdelta/Smart-Contracts that referenced this pull request Mar 9, 2018
Update to truffle 4.0.0 and solc 0.4.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants