Crowdsale inheritance order #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
requested changes
Aug 1, 2018
There was a problem hiding this comment.
Thanks @nventuro! I believe we should make the same change in FinalizableCrowdsale. Can you take a look at it?
|
Actually that's the issue that was reported in #1110. I thought this PR was fixing that one. |
|
Huh, I somehow missed that issue, thanks! |
frangio
approved these changes
Aug 2, 2018
frangio
pushed a commit
that referenced
this pull request
Aug 2, 2018
* Changed Crowdsale inheritance order. * Changed FinalizableCrowdsale inheritance order. (cherry picked from commit 3d86c58)
mattgstevens
added a commit
to fanzone-media/ERC725
that referenced
this pull request
Jun 21, 2021
this solves a solc compile error "TypeError: Linearization of inheritance graph impossible" by inheriting the "most base-like" contracts first to prevent errors from inheriting contract. See a similar fix here OpenZeppelin/openzeppelin-contracts#1128
mattgstevens
added a commit
to fanzone-media/ERC725
that referenced
this pull request
Jun 21, 2021
this solves a solc compile error `TypeError: Linearization of inheritance graph impossible` by inheriting the "most base-like" contracts first to prevent errors from inheriting contract. See a similar fix here OpenZeppelin/openzeppelin-contracts#1128
mattgstevens
added a commit
to fanzone-media/ERC725
that referenced
this pull request
Sep 3, 2021
this solves a solc compile error `TypeError: Linearization of inheritance graph impossible` by inheriting the "most base-like" contracts first to prevent errors from inheriting contract. See a similar fix here OpenZeppelin/openzeppelin-contracts#1128
mattgstevens
added a commit
to fanzone-media/ERC725
that referenced
this pull request
Sep 14, 2021
this solves a solc compile error `TypeError: Linearization of inheritance graph impossible` by inheriting the "most base-like" contracts first to prevent errors from inheriting contract. See a similar fix here OpenZeppelin/openzeppelin-contracts#1128
mattgstevens
added a commit
to fanzone-media/ERC725
that referenced
this pull request
Sep 23, 2021
this solves a solc compile error `TypeError: Linearization of inheritance graph impossible` by inheriting the "most base-like" contracts first to prevent errors from inheriting contract. See a similar fix here OpenZeppelin/openzeppelin-contracts#1128
mattgstevens
added a commit
to fanzone-media/ERC725
that referenced
this pull request
Sep 23, 2021
this solves a solc compile error `TypeError: Linearization of inheritance graph impossible` by inheriting the "most base-like" contracts first to prevent errors from inheriting contract. See a similar fix here OpenZeppelin/openzeppelin-contracts#1128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some derived Crowdsale contracts were impossible to build due to the specified inheritance order of the Crowdsales (see ##1124), this prevents that.
Fixes #1124.
Fixes #1110.