Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix all parameters with underscore #1133

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Prefix all parameters with underscore #1133

merged 1 commit into from
Jul 31, 2018

Conversation

come-maiz
Copy link
Contributor

🚀 Description

Consistently use an underscore as a prefix to identify parameters.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

shrugs
shrugs approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@shrugs shrugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏I hope that our test coverage is good enough to cover all possible routes here 😂

but looks good to me :)

@nventuro nventuro merged commit 2765350 into OpenZeppelin:master Jul 31, 2018
@come-maiz come-maiz deleted the refactor/params-prefix-underscore branch July 31, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrugs shrugs shrugs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@come-maiz @shrugs @nventuro