Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated ERC721._burn(address, uint256) #1550

Merged
merged 2 commits into from Dec 11, 2018

Conversation

@nventuro
Copy link
Member

commented Dec 11, 2018

The old interface made no sense, since the address could only be the owner of the token. This PR adds a saner alternative, keeping the underlying behavior.

@nventuro nventuro added this to the v2.1 milestone Dec 11, 2018

@nventuro nventuro self-assigned this Dec 11, 2018

@nventuro nventuro requested a review from frangio Dec 11, 2018

@frangio
Copy link
Member

left a comment

Stability 🌈

contracts/token/ERC721/ERC721.sol Show resolved Hide resolved
contracts/token/ERC721/ERC721.sol Show resolved Hide resolved

@frangio frangio merged commit dd2e947 into OpenZeppelin:master Dec 11, 2018

2 checks passed

Travis CI - Pull Request Build Passed
Details
coverage/coveralls First build on deprecate-721-burn at 100.0%
Details

@nventuro nventuro deleted the nventuro:deprecate-721-burn branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.