Update StandardToken.sol #224
Conversation
Added increaseApproval and decreaseApproval to increase / decrease the approval in 1 transaction.
|
I like this approach. Thanks for the contribution |
|
@pipaman ping on adding tests ;) |
There was a problem hiding this comment.
I did a little investigation on why the CI build passed when the PR does not include the implementation of the onlyPayloadSize() modifier for the two added functions. Turns out the project's dependencies (EDIT: at the time) got an older version of the solc compiler (0.4.8) which does not complain about such issues as more up to date versions do (0.4.14). Time to upgrade dependencies?
| * From MonolithDAO Token.sol | ||
| */ | ||
| function increaseApproval (address _spender, uint _addedValue) | ||
| onlyPayloadSize(2 * 32) |
There was a problem hiding this comment.
I'm assuming we want to use the MonolithDAO's implementation of the onlyPayloadSize() modifier? The contract doesn't even build due missing implementation.
There was a problem hiding this comment.
Never mind the previous comment about dependencies. I'm working on this.
There was a problem hiding this comment.
onlyPayloadSize was removed (#277). This PR should should have the modifier removed.
Added onlyPayloadSize modifier implementation for PR OpenZeppelin#224.
- Spender starts with 0 tokens allowed to spend - Spender is granted 50, then decreased it's allowance by 10 Refs PR OpenZeppelin#224
- Spender starts with 0 tokens allowed to spend - Spender is granted 50, then decreased it's allowance by 10 Refs PR OpenZeppelin#224
|
@pipaman ping ping |
- Spender starts with 0 tokens allowed to spend - Spender is granted 50, then decreased it's allowance by 10 Refs PR OpenZeppelin#224
Added tests for PR OpenZeppelin#224
|
Closing since it is already implemented. Thanks! |
Added increaseApproval and decreaseApproval to increase / decrease the approval in 1 transaction.