Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SafeERC20.safeApprove #2268

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Jun 5, 2020

Fixes #2219

@nventuro nventuro requested a review from frangio June 5, 2020 15:39
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nventuro nventuro merged commit d3ef93a into OpenZeppelin:master Jun 5, 2020
@nventuro nventuro deleted the safe-erc20-deprecate branch June 5, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SafeERC20.safeApprove() Has unnecessary and unsecure added behavior
2 participants