Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use beforeTokenTransfer hook in ERC20Snapshot #2312

Merged
merged 1 commit into from
Aug 11, 2020
Merged

feat: use beforeTokenTransfer hook in ERC20Snapshot #2312

merged 1 commit into from
Aug 11, 2020

Conversation

julianmrodri
Copy link
Contributor

2283

Fixes #2283

  • Implements Snapshot updates using _beforeTokenTransfer hook, avoiding to override _mint, _burn, and _transfer.

@julianmrodri julianmrodri force-pushed the feat/erc20Snapshot-hooks-#2283 branch from a6e460e to 917cbd9 Compare July 14, 2020 21:50
@stale
Copy link

stale bot commented Jul 29, 2020

Hi all!
This Pull Request has not had any recent activity, is it still relevant? If so, what is blocking it? Is there anything we can do to help move it forward?
Thanks!

@stale stale bot added the stale label Jul 29, 2020
@frangio frangio removed the stale label Aug 11, 2020
frangio
frangio approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@frangio frangio merged commit 9700e6b into OpenZeppelin:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC20Snapshot should use hooks
2 participants
@julianmrodri @frangio