Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimelockController #2354

Merged
merged 74 commits into from
Sep 17, 2020
Merged

Add TimelockController #2354

merged 74 commits into from
Sep 17, 2020

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Sep 9, 2020

A contract to enable timelocked maintenance operations. Particularly usefull when EOA or multisigs are in charge of smart contract updates.

This PR includes:

  • Contract
  • Testing
  • Documentation

Many design characteristics have been discussed on Slack before arriving to this result, but I'll be able to discuss them again here and eventually change some details.

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

test/access/TimelockController.test.js Outdated Show resolved Hide resolved
test/access/TimelockController.test.js Outdated Show resolved Hide resolved
test/access/TimelockController.test.js Outdated Show resolved Hide resolved
test/access/TimelockController.test.js Outdated Show resolved Hide resolved
test/access/TimelockController.test.js Outdated Show resolved Hide resolved
contracts/access/README.adoc Outdated Show resolved Hide resolved
contracts/access/README.adoc Outdated Show resolved Hide resolved
contracts/access/README.adoc Outdated Show resolved Hide resolved
contracts/access/README.adoc Outdated Show resolved Hide resolved
contracts/access/README.adoc Show resolved Hide resolved
Amxx and others added 13 commits September 15, 2020 14:32
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Copy link
Collaborator Author

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressing review cd0b97c

contracts/access/README.adoc Outdated Show resolved Hide resolved
contracts/access/TimelockController.sol Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/access-control.adoc Outdated Show resolved Hide resolved
@frangio frangio changed the title Timelock Add TimelockController Sep 17, 2020
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@frangio frangio merged commit 7f3eee7 into OpenZeppelin:master Sep 17, 2020
@Amxx Amxx deleted the timelock-public branch January 4, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants