Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enabling safemath revert reasons in ERC20, ERC777 and ERC1155 #2491

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 29, 2021

This PR adds revert message on some overflow errors in ERC20 and ERC1155. These revert message used to be part of 3.x and were removed during the transition to 0.8.0's built in safemath.

  • Tests

@Amxx Amxx force-pushed the feature/reEnableRevertReason branch from c3a46e8 to fb810ee Compare January 29, 2021 13:38
@Amxx Amxx changed the title re-enabling safemath revert reasons in ERC20 and ERC1155 re-enabling safemath revert reasons in ERC20, ERC777 and ERC1155 Jan 29, 2021
@Amxx
Copy link
Collaborator Author

Amxx commented Jan 29, 2021

Adding the revert messages back to ERC777 as well.

@Amxx Amxx merged commit 5db7413 into OpenZeppelin:solc-0.8 Feb 1, 2021
@Amxx Amxx deleted the feature/reEnableRevertReason branch February 1, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant