Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ownable should support setting the initial owner through its constructor #2639 #2647

Closed
wants to merge 3 commits into from
Closed

Ownable should support setting the initial owner through its constructor #2639 #2647

wants to merge 3 commits into from

Conversation

Manik-Jain
Copy link
Contributor

@Manik-Jain Manik-Jain commented Apr 27, 2021 •
edited
Loading

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Manik-Jain Manik-Jain mentioned this pull request Apr 27, 2021
Closed
@Amxx
Copy link
Collaborator

Amxx commented Apr 27, 2021

This has already been discussed in #2639 and #2402.
Variables are private for a reason, which is that there are script rules on how can perform a change. Additionally, we need to guaranty that no change happens without an event be emitted.

We have a discussion here #2567 about providing an internal setter. Please contribute to the discussion there.

@Amxx Amxx closed this Apr 27, 2021
@Amxx Amxx mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Manik-Jain @Amxx