Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessControlEnumerable: Hook into the internal function #2946

merged 2 commits into from Nov 8, 2021


Copy link

@Amxx Amxx commented Nov 4, 2021

Since AccessControl now expauses _grantRole and _reboveRole as internal function, AccessControlEnumerable should hook into that.

Fixes #2938

PR Checklist

  • Tests
  • Changelog entry

@Amxx Amxx requested a review from frangio November 6, 2021 13:22
Copy link

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@frangio frangio merged commit 7579828 into OpenZeppelin:master Nov 8, 2021
frangio pushed a commit that referenced this pull request Nov 8, 2021
* AccessControlEnumerable: Hook into the internal function

* add changelog entry

(cherry picked from commit 7579828)
Copy link

frangio commented Nov 8, 2021

Cherry picked onto 4.4.

@Amxx Amxx deleted the fix/AccessEnumerableInternal branch November 8, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

AccessControlEnumerable doesn't override all internal functions
2 participants