Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GovernorTimelockControl.state() to detect direct cancel #2977

Merged
merged 2 commits into from Nov 18, 2021
Merged

Improve GovernorTimelockControl.state() to detect direct cancel #2977

merged 2 commits into from Nov 18, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Nov 17, 2021 •
edited

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@frangio frangio changed the title improve GovernorTimelockControl override of state() to detect cancel in timelock Improve GovernorTimelockControl.state() to detect direct cancel Nov 18, 2021
@frangio
Copy link
Contributor

frangio commented Nov 18, 2021

Implementation and test look good to me. I think it deserves a changelog entry though.

frangio
frangio approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@frangio frangio merged commit a57e638 into OpenZeppelin:master Nov 18, 2021
@Amxx Amxx deleted the feature/Governor/improveTimelockControlState branch November 18, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amxx @frangio