Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ERC1967 pragma to 0.8.4 #3036

Closed
wants to merge 1 commit into from
Closed

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Dec 17, 2021

Fixes #2979

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx mentioned this pull request Dec 17, 2021
@frangio
Copy link
Contributor

frangio commented Dec 20, 2021

I don't really understand, it looks like the current code compiles fine with 0.8.2. Can you confirm that this is necessary?

@Amxx
Copy link
Collaborator Author

Amxx commented Dec 20, 2021

In remix, with 0.8.2 selected, I am able to compile

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

import "https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/proxy/ERC1967/ERC1967Upgrade.sol";

@frangio
Copy link
Contributor

frangio commented Dec 20, 2021

Ok then if I understand correctly this can be closed.

@frangio frangio closed this Dec 20, 2021
@Amxx Amxx deleted the fix/pragma branch December 29, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERC1967Upgrade.sol does not compile using Solidity 0.8.2
2 participants