Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename isContract to hasCode #3418

Closed
wants to merge 1 commit into from
Closed

Rename isContract to hasCode #3418

wants to merge 1 commit into from

Conversation

devtooligan
Copy link

This pr addresses #3417

This pr renames the isContract fn to hasCode.

Changes include:

  • rename the function
  • update docs
  • update tests and test documentation
  • changelog entry
  • update erc1967 error message

PR Checklist

  • [ x ] Tests
  • [ x ] Documentation
  • [ x ] Changelog entry

@devtooligan devtooligan force-pushed the rename-iscontract-to-hascode branch from 1240e4f to cd4c4e5 Compare May 17, 2022 17:09
@Amxx
Copy link
Collaborator

Amxx commented May 17, 2022

This is a breaking change that would require a major release (5.0).

There is a discussion going on in #3417 (and in many many other issues/posts).

@Amxx Amxx closed this May 17, 2022
@Amxx Amxx added the breaking change Changes that break backwards compatibility of the public API. label May 17, 2022
@Amxx Amxx added this to the 5.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devtooligan @Amxx