Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change admin role allocation in TimelockControler constructor #3722

Merged
merged 10 commits into from
Sep 23, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Sep 22, 2022

Fixes #3720

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx marked this pull request as ready for review September 22, 2022 17:42
@Amxx Amxx requested a review from frangio September 22, 2022 17:42
contracts/governance/TimelockController.sol Outdated Show resolved Hide resolved
contracts/governance/TimelockController.sol Outdated Show resolved Hide resolved
contracts/governance/TimelockController.sol Outdated Show resolved Hide resolved
contracts/governance/README.adoc Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@frangio
Copy link
Contributor

frangio commented Sep 22, 2022

This looks good, my only remaining question is if we should include a warning note in the documentation about past versions of the timelock and their treatment of the deployer account.

@Amxx
Copy link
Collaborator Author

Amxx commented Sep 22, 2022

Its true that we don't keep past version of the doc for every minor... I think this is something we should do in the future (each version is build from the corresponding release branch)

Fell free to add any additional warning.

@Amxx Amxx merged commit 408055d into OpenZeppelin:master Sep 23, 2022
@Amxx Amxx deleted the fix/timelockcontroler/admin branch September 23, 2022 14:58
frangio pushed a commit that referenced this pull request Sep 23, 2022
Co-authored-by: Francisco <frangio.1@gmail.com>
(cherry picked from commit 408055d)
JulissaDantes pushed a commit to JulissaDantes/openzeppelin-contracts that referenced this pull request Nov 3, 2022
JulissaDantes pushed a commit to JulissaDantes/openzeppelin-contracts that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explicit admin address to TimelockControl constructor
3 participants