Use unchecked in ERC20Votes and fix typo #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✍️ minor typo fix in comments
🧮 use unchecked {} for simple arithmetic where underflow is obvious in preceding statement
✍️ typo fix
fix memo
frangio
changed the title
|
I think this is ok. Just wish there was a more localized way to use unchecked in |
Amxx
previously approved these changes
Oct 17, 2022
Amxx
approved these changes
Oct 17, 2022
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 OpenZeppelin Contracts Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
JulissaDantes
pushed a commit
to JulissaDantes/openzeppelin-contracts
that referenced
this pull request
Nov 3, 2022
Co-authored-by: Francisco Giordano <frangio.1@gmail.com> Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ minor typo fix in comments
🧮 use unchecked {} for simple arithmetic where underflow check is obvious in preceding statement
Fixes #????
PR Checklist