Use default admin role in TimelockController #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Socket Security Pull Request Report👍 No dependency changes detected in pull request Pull request report summary
Powered by socket.dev |
|
That PR looks way bigger than it needs to be. |
|
Seems like the PR includes everything from |
JulissaDantes
force-pushed
the
timelock-roles
branch
from
a107938
to
95a548f
Compare
|
Now it's ready! |
|
@JulissaDantes Can you rebase on
|
Amxx
reviewed
Nov 4, 2022
Amxx
reviewed
Nov 4, 2022
Amxx
reviewed
Nov 4, 2022
Amxx
reviewed
Nov 4, 2022
| @@ -28547,4 +28547,4 @@ | |||
| "dev": true | |||
| } | |||
| } | |||
| } | |||
| } | |||
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
JulissaDantes
force-pushed
the
timelock-roles
branch
from
1b3e1c4
to
5da88e1
Compare
frangio
reviewed
Nov 7, 2022
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 OpenZeppelin Contracts Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3389
The TimelockController contract currently uses a custom non-zero TIMELOCK_ADMIN role, in order to make easier the introduction of new roles without custom migrations the DEFAULT_ADMIN_ROLE needs to be used.
PR Checklist