Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release note in IERC1967 #4183

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix release note in IERC1967 #4183

merged 1 commit into from
Apr 25, 2023

Conversation

pcaversaccio
Copy link
Contributor

As title. If you think this requires a CHANGESET, I can create one.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2023

⚠️ No Changeset found

Latest commit: 2167d7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although there's an overflow in our Checkpoints fuzzing templates, looking into it. No need for a changeset though, thanks!

@pcaversaccio
Copy link
Contributor Author

I guess this PR #4184 blocks the merging of this PR, correct @ernestognw?

@ernestognw
Copy link
Member

ernestognw commented Apr 24, 2023

I guess this PR #4184 blocks the merging of this PR, correct @ernestognw?

Not really, they can be merged separately. I'm waiting for a second review as per policy (and the team was out last week), I'm adding review requests so thanks for the heads up.

@ernestognw ernestognw requested review from frangio and Amxx April 24, 2023 13:02
@frangio frangio merged commit f959d7e into OpenZeppelin:master Apr 25, 2023
13 of 16 checks passed
@pcaversaccio pcaversaccio deleted the patch-1 branch April 25, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants