You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
By removing upgradeTo and changing the behavior of upgradeToAndCall this would seem to cause issues with OpenZeppelin Upgrades Plugins and other similar tooling. If we want to go ahead with this we would need a solution to detect which function to call, but it seems complicated.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amxx
force-pushed
the
refactor/removeUpgradeWithoutCall
branch
from
Depends on #4354 (conflicts will have to be fixed)
Remove the upgradeToAndCall to reduce the size (and deployment cost) of:
This includes a refactor of the upgradeToAndCall workflow: if the calldata for the call is empty, is call is no longer performed.
PR Checklist
npx changeset add)