Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retyped and renamed storage layout annotations #4423

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Jul 5, 2023

Removes all @custom:oz-retyped-from and @custom:oz-renamed-from annotations for storage layout checks from OpenZeppelin Upgrades Plugins.

Also removes the @custom:storage-size annotations for the transpiler, all of them found in upgradeable.patch.

The changes to storage layout need to be documented in the changelog but the storage-size change is the least of changes given the upcoming change to namespaced storage.

Fixes LIB-932
Fixes LIB-866

@frangio frangio requested a review from a team July 5, 2023 01:19
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

⚠️ No Changeset found

Latest commit: 9284dc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frangio frangio requested a review from a team July 5, 2023 19:23
@frangio
Copy link
Contributor Author

frangio commented Jul 5, 2023

Note: The concern about EIP712 was resolved in #4424 (comment)

Storage layout checks are failing because of the change to gap sizes.

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frangio frangio merged commit 3ff9b42 into OpenZeppelin:master Jul 5, 2023
16 of 18 checks passed
@frangio frangio deleted the remove-annotations branch July 5, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants