Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use named arguments in mapping types #4433

Merged
merged 11 commits into from
Aug 9, 2023
Merged

Use named arguments in mapping types #4433

merged 11 commits into from
Aug 9, 2023

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented Jul 6, 2023 •
edited

Fixes #4343

After bumping pragma to 0.8.19 in #4288, we're now able to add named arguments to mapping types. This PR solves that.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@ernestognw ernestognw requested review from frangio and Amxx July 6, 2023 20:32
@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023 •
edited

⚠️ No Changeset found

Latest commit: 3d0d654

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Amxx
Amxx reviewed Jul 7, 2023
View reviewed changes
contracts/access/AccessControl.sol Outdated Show resolved Hide resolved
contracts/mocks/compound/CompTimelock.sol Outdated Show resolved Hide resolved
contracts/token/ERC1155/extensions/ERC1155URIStorage.sol Outdated Show resolved Hide resolved
contracts/token/ERC721/ERC721.sol Outdated Show resolved Hide resolved
contracts/token/ERC721/extensions/ERC721URIStorage.sol Outdated Show resolved Hide resolved
@ernestognw @Amxx
Apply suggestions
7aee585 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw ernestognw requested a review from Amxx July 8, 2023 00:55
@ernestognw ernestognw requested a review from Amxx July 12, 2023 00:51
Amxx
Amxx previously approved these changes Jul 12, 2023
View reviewed changes
@RenanSouza2
Copy link
Contributor

just a reminder to link this PR to issue #4343

@ernestognw
Copy link
Member Author

ernestognw commented Jul 16, 2023 •
edited

just a reminder to link this PR to issue #4343

Thanks for the heads up @RenanSouza2, just linked

@ernestognw ernestognw requested a review from Amxx July 28, 2023 04:05
Amxx
Amxx previously approved these changes Jul 28, 2023
View reviewed changes
@Amxx Amxx mentioned this pull request Jul 31, 2023
Closed
@ernestognw ernestognw requested a review from frangio August 8, 2023 20:07
frangio
frangio approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frangio
Copy link
Contributor

frangio commented Aug 9, 2023

Storage layout check failing because of renamed variables or struct members, as expected, but ok for 5.0.

@frangio frangio merged commit cb0ffef into OpenZeppelin:master Aug 9, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RenanSouza2 RenanSouza2 RenanSouza2 left review comments

@frangio frangio frangio approved these changes

@Amxx Amxx Amxx left review comments

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement named parameters in mapping types
4 participants
@ernestognw @RenanSouza2 @frangio @Amxx