Rename rounding modes and complete with fourth #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 12e6dad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amxx
previously approved these changes
Jul 13, 2023
|
I'm pushing a commit with rounding comments updates where I considered appropriate. |
Amxx
previously approved these changes
Jul 13, 2023
ernestognw
reviewed
Jul 13, 2023
|
Hey guys, just noticed that this change has not been mentioned in breaking changes, and the docs are also not updated.
|
|
@Zartaj0 you are looking at the v4 documentation. Documentation for v5 is up to date: |
|
Oh yes, My bad. Didn't check commenting. Thanks @Amxx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #4185 "up" and "down" are potentially confusing, and there is more precise terminology that we should be using. Additionally, 3 rounding modes are not enough when it comes to signed numbers, so we've added the missing 4th rounding mode.
Fixes #4185
Fixes LIB-949
Needs tests for new rounding mode.