Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessManager tests consolidation #4655

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

ernestognw
Copy link
Member

After #4642, #4632 and #4642, some improvements were left out. This PR adds missing review comments, tests cases, consolidated utilities, and also improves documentation for AccessManager tests.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: ba61108

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Amxx
Amxx previously approved these changes Oct 5, 2023
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test/helpers/namespaced-storage.js can probably be improved using ethers instead of web3, but we'll do that during the migration.

LGTM

@ernestognw
Copy link
Member Author

Definitely, let's wait until migrating AccessManager tests to ethers.
Merging

@ernestognw ernestognw merged commit 6383299 into OpenZeppelin:master Oct 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants