Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC1363 error signatures #5010

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Update ERC1363 error signatures #5010

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac68b32
Update ERC1363 error signatures
vittominacori Apr 10, 2024
0a2dc05
Add natspec comments for params to ERC1363 errors
vittominacori Apr 10, 2024
42d99bf
Update contracts/token/ERC20/extensions/ERC1363.sol
ernestognw Jun 4, 2024
1bd7ca1
Update contracts/token/ERC20/extensions/ERC1363.sol
ernestognw Jun 4, 2024
35f5329
Apply suggestions from code review
ernestognw Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions contracts/token/ERC20/extensions/ERC1363.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,23 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {

/**
* @dev Indicates a failure within the {transfer} part of a transferAndCall operation.
* @param receiver The address to which tokens are being transferred.
ernestognw marked this conversation as resolved.
Show resolved Hide resolved
* @param value The amount of tokens to be transferred.
ernestognw marked this conversation as resolved.
Show resolved Hide resolved
*/
error ERC1363TransferFailed(address to, uint256 value);
error ERC1363TransferFailed(address receiver, uint256 value);

/**
* @dev Indicates a failure within the {transferFrom} part of a transferFromAndCall operation.
* @param sender The address from which to send tokens.
* @param receiver The address to which tokens are being transferred.
* @param value The amount of tokens to be transferred.
ernestognw marked this conversation as resolved.
Show resolved Hide resolved
*/
error ERC1363TransferFromFailed(address from, address to, uint256 value);
error ERC1363TransferFromFailed(address sender, address receiver, uint256 value);

/**
* @dev Indicates a failure within the {approve} part of a approveAndCall operation.
* @param spender The address which will spend the funds.
* @param value The amount of tokens to be spent.
ernestognw marked this conversation as resolved.
Show resolved Hide resolved
*/
error ERC1363ApproveFailed(address spender, uint256 value);

Expand Down
Loading