Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas loop optimization in MerkleProof.sol #5036

Closed
wants to merge 8 commits into from
Closed

Gas loop optimization in MerkleProof.sol #5036

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c9b7c9b
fix gas loop optimization in MerkleProof.sol (#5028)
CarsonCase May 9, 2024
9e2ba99
fix gas loop optimization in MerkleProof.sol | caching length (#5028)
CarsonCase May 9, 2024
6845307
remove unchecked block and make variable explicit
cairoeth May 31, 2024
ec86972
add increase for loops
cairoeth May 31, 2024
12ef695
Merge branch 'master' into loopGasOptimization
cairoeth May 31, 2024
d58f537
add changeset
cairoeth May 31, 2024
68598d9
Merge branch 'loopGasOptimization' of https://github.com/CarsonCase/o…
cairoeth May 31, 2024
27654f7
Delete funny-houses-thank.md
cairoeth May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions contracts/utils/cryptography/MerkleProof.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ library MerkleProof {
*/
function processProof(bytes32[] memory proof, bytes32 leaf) internal pure returns (bytes32) {
bytes32 computedHash = leaf;
for (uint256 i = 0; i < proof.length; i++) {
uint256 len = proof.length;
for (uint256 i = 0; i < len; i++) {
computedHash = Hashes.commutativeKeccak256(computedHash, proof[i]);
}
return computedHash;
Expand All @@ -61,7 +62,8 @@ library MerkleProof {
*/
function processProofCalldata(bytes32[] calldata proof, bytes32 leaf) internal pure returns (bytes32) {
bytes32 computedHash = leaf;
for (uint256 i = 0; i < proof.length; i++) {
uint256 len = proof.length;
for (uint256 i = 0; i < len; i++) {
computedHash = Hashes.commutativeKeccak256(computedHash, proof[i]);
}
return computedHash;
Expand Down