Procedurally generate packing libraries #5051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Type |
|---|---|
| openzeppelin-solidity | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
Unit tests are missing. Will update later |
ernestognw
changed the title
This was referenced May 23, 2024
|
In favor of #5056 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the new (unreleased) Packing library to be automatically generated. It allows for packing values into
bytes32,bytes16,bytes8andbytes4.I decided to split the contract in
PackingBytes32,PackingBytes16,PackingBytes8andPackingBytes4. The reason is that when function identifiers collide (i.e. there are multiple definitions ofatandpackso the compiler can't dissambiguate).The alternative is to give users instructions of how to apply the
usingsyntax to only apply the functions to those types intended. This is simpler imo.PR Checklist
npx changeset add)