Minor standards and cleanup additions.

[shrugs]

• more comprehensive gitignore
• use env variables instead of magic string to choose mnemonic and infura access
• update yarn lock ( Redundant lockfiles (npm and yarn) #284 )
• an eslint configuration based on standard (with a global --fix applied)
• renaming all test files to add .test.js as a suffix to match traditional testing standards
• moving all of the mocked solidity files into a mocks/ directory.
• manually fixing linting errors in tests where appropriate

---

Discussion

I'm very partial to the space-before-function-paren (always) and semi rules (never), but I understand if people think differently. Regardless of which direction we pick, we should enforce it, so the questions are:

1. should we enforce spaces before function parens? i.e. function () {} vs function() {} and (in classes) functionName () {} vs functionName() {}. I think the former looks prettier, but ¯\_(ツ)_/¯
2. should we enforce semicolons or not? I'm partial to "no semicolons unless logically required".

---

I'm aware that this is a massive PR and would mostly likely require rebasing any outstanding PRs to avoid merge conflicts. If anyone has strong opinions on that, please voice them.

[frangio]

should we enforce spaces before function parens?

I'd go with always. 👍

should we enforce semicolons or not? I'm partial to "no semicolons unless logically required".

Although I agree it looks prettier, I feel more comfortable if we consistently use semicolons. I'm open to discussion but I think it's definitely the most robust thing to do, and we should aim for robustness. Additionally, most of the repo is already using semicolons, and most of this PR consists of removing them, so it would help make it somewhat less "massive". 😃

Other than that, this is a welcome addition! Great work.

[frangio]

Is this needed in dependencies or could it go in devDependencies? It only seems necessary if you want to run the tests.

[shrugs]

It's required at runtime for truffle.js, so theoretically it belongs in dependencies. But we really only use truffle for tests, since anyone using this project is including it as a dependency and using their own truffle.

It's up to you. We can also remove it, but being able to include a .env file for things like MNEMONIC and infura api keys is a lot easier than making sure to export them in your environment or include them in the command line when you run truffle

[frangio]

Let's leave it this way. dotenv has no production dependencies anyway.

[shrugs]

@frangio added the rules and applied an autofix. We'll want to squash that commit correctly before merging, most likely.

[shrugs]

rebased and updated; sqashed the semicolon fix to 8662846

[frangio]

Thanks so much @shrugs! 🙌

[AugustoL]

Seeing this just now, @shrugs 👏 👏