feat: update pr templates, closes #696 #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Jan 24, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] ✅ I've added tests where applicable to test my new functionality. | ||
| - [ ] 📖 I've made sure that my contracts are well-documented. | ||
| - [ ] 🎨 I've run the JS/Solidity linters (`npm run lint:all:fix`) and fixed any issues. |
There was a problem hiding this comment.
While we're at it, I'd move the command in parentheses to the end of the sentence, after "fixed any issues".
frangio
approved these changes
Jan 24, 2018
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
* feat: update pr templates, closes OpenZeppelin#696 * fix: move lint command to end of bullet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
🚀 Description
Puts the checkbox content at the bottom of the page so the open graph tags are relevant.
npm run lint:all:fix) and fixed any issues.