Improve ERC20 tests coverage #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
force-pushed
the
enhancement/provide_more_erc20_tests
branch
from
d0d6599
to
4018821
Compare
facuspagnuolo
force-pushed
the
enhancement/provide_more_erc20_tests
branch
from
4018821
to
02f8f5a
Compare
facuspagnuolo
force-pushed
the
enhancement/provide_more_erc20_tests
branch
from
4bf6092
to
94fc8ed
Compare
|
Moreover, if we get this PR merged, it fixes #548 |
test/token/BasicToken.test.js
Outdated
| describe('when the sender has enough balance', function () { | ||
| const amount = 100; | ||
|
|
||
| it('transfer the requested amount', async function () { |
There was a problem hiding this comment.
should be transfers instead of transfer
There was a problem hiding this comment.
nice catch! thx @gertjanleemans
|
This one became a bit of a hassle to review. I would have preferred 5 different pull requests that are easier to review and merge. |
|
totally agree @federicobond... sorry for that and thanks a lot for reviewing it :) |
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
* Improve StandardToken tests coverage * Improve BasicToken test coverage * Improve MintableToken test coverage * Improve BurnableToken test coverage * Improve PausableToken tests coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686 & #616