Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ownable behavior #929

Merged
merged 9 commits into from May 9, 2018
Merged

Ownable behavior #929

merged 9 commits into from May 9, 2018

Conversation

pw94
Copy link
Contributor

@pw94 pw94 commented May 4, 2018

Fixes #905

🚀 Description

I extracted an Ownable behavior for testing

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@shrugs
Copy link
Contributor

shrugs commented May 7, 2018

@pw94 nice! we're slowly in the process of converting all of the assertions to use should, and Ownable doesn't have them because it was written rather early. Would you mind converting the behavior to use should assertions in a second commit?

shrugs
shrugs approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@shrugs shrugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @pw94 !

@shrugs shrugs merged commit 20b85be into OpenZeppelin:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrugs shrugs shrugs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide an Ownable behavior for testing
2 participants
@pw94 @shrugs