Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Whitelist contract to access directory #994

Merged
merged 1 commit into from Jun 11, 2018
Merged

Move Whitelist contract to access directory #994

merged 1 commit into from Jun 11, 2018

Conversation

arku
Copy link
Contributor

@arku arku commented Jun 11, 2018 •
edited

Fixes #988

🚀 Description

  • Moves Whitelist.sol from contracts/ownership to contracts/access
  • Updates references to solidity files in Whitelist.sol and WhitelistMock.sol
  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@arku arku mentioned this pull request Jun 11, 2018
Closed
1 task
@arku arku force-pushed the fix/whitelist-location-move-#988 branch from 5f9b5bf to 6a2875f Compare June 11, 2018 01:21
shrugs
shrugs approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@shrugs shrugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@frangio frangio merged commit 9f1d294 into OpenZeppelin:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrugs shrugs shrugs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whitelist.sol should live in /access
3 participants
@arku @shrugs @frangio