Skip to content
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.

Review naming #9

Open
frangio opened this issue Aug 1, 2019 · 2 comments
Open

Review naming #9

frangio opened this issue Aug 1, 2019 · 2 comments
Assignees

Comments

@frangio
Copy link
Contributor

frangio commented Aug 1, 2019

There's a couple of names I think we should review.

  • Web3Context: This library will generally be used alongside React, where Context already has a meaning that is unrelated to how we're using the word.
  • web3Context.lib: The lib property on Web3Context instances holds the Web3 instance initialized with the provider. It's a very generic name. IMO, ideally the property would be web3.
  • useWeb3Network/fromConnection: This React hook and its corresponding factory have unrelated names, even though they are both wrappers around the same functionality.
@ylv-io
Copy link
Contributor

ylv-io commented Aug 5, 2019

I'd love to swap Context for something more sound. Couldn't come up with anything better. Any ideas are welcome.
Regarding renaming lib for web3. The issue with web3 is that a lot of things are called web3 and having Web3Context.web3 property seems as overkill. If we rename Web3Context to something different than web3 would be more viable option.

@PaulRBerg
Copy link

For the first one, maybe Web3Env or Web3Environment or Web3Wrapper?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants