Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Ability to pass false booleans via the cli #558

Closed
theethernaut opened this issue Jan 7, 2019 · 0 comments · Fixed by #623
Closed

Ability to pass false booleans via the cli #558

theethernaut opened this issue Jan 7, 2019 · 0 comments · Fixed by #623
Assignees
Labels
kind:enhancement Enhancement to an existing feature
Milestone

Comments

@theethernaut
Copy link
Contributor

theethernaut commented Jan 7, 2019

Atm, calling something like

zos create MyContract --init --args false

cli/src/utils/input.ts will parse false as the string "false", and when this value is passed to lib/helpers/encodeCall.ts, the encoding will interpret "false" as the boolean true.

input.ts should account for such booleans (as opposed to encodeCall.ts doing it in order to maintain compatibility with Web3).

@theethernaut theethernaut changed the title Ability to pass booleans via the cli Ability to pass false booleans via the cli Jan 7, 2019
@facuspagnuolo facuspagnuolo added this to the v2.2.0 milestone Jan 8, 2019
@facuspagnuolo facuspagnuolo added kind:enhancement Enhancement to an existing feature and removed kind:bug labels Jan 8, 2019
@theethernaut theethernaut self-assigned this Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants