This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Fixes for 2.8 #1473
Merged
Fixes for 2.8 #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm worried that none of these fixes has any tests. If we are considering migrating all commands to the new spec format, then we need to add tests for this layer, as we do with the current version. Also, for the future, let's split fixes for different issues into different PRs, even if they are small. |
spalladino
approved these changes
Feb 19, 2020
| @@ -108,7 +108,7 @@ export const options: Option[] = [ | |||
| const networks = ConfigManager.getNetworkNamesFromConfig(); | |||
| const { network: lastNetwork, expired } = Session.getNetwork(); | |||
|
|
|||
| if (expired) { | |||
| if (expired || lastNetwork === undefined) { | |||
There was a problem hiding this comment.
This should be ported to verify as well
spalladino
pushed a commit
that referenced
this pull request
Feb 19, 2020
|
Cherry-picked to 2.8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1470.
Fixes #1471.
Fixes #1468.