Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Replaces ethereumjs-abi with ethers.js/abi-coder #556

Merged
merged 11 commits into from
Jan 9, 2019
Merged

Replaces ethereumjs-abi with ethers.js/abi-coder #556

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
673cbd8
Replaced ethereumjs-abi with ethers.js/abi-coder
theethernaut Jan 5, 2019
db2bdea
Update package-lock file.
theethernaut Jan 5, 2019
01c8bf8
Adds tests for tuple types in encodeCall.
theethernaut Jan 6, 2019
58236fc
Remove attempt to test function types in encodeCall.
theethernaut Jan 6, 2019
222d3ec
Add a couple of tests and comments to encodeCall.
theethernaut Jan 7, 2019
7e5da97
encodeCall tests compare encoded vs decoded values, and not just veri…
theethernaut Jan 7, 2019
d0f80d5
Parse bool types in encodeCall.
theethernaut Jan 7, 2019
b2148e8
Remove web3-utils dependency and some only's from encodeCall tests.
theethernaut Jan 7, 2019
c3a9073
Remove parsing entirely from encodeCall.
theethernaut Jan 7, 2019
0777e48
Update a package-lock file.
theethernaut Jan 7, 2019
5d39111
Small changes requested by @facuspagnuolo.
theethernaut Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/cli/test/scripts/create.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,10 @@ contract('create script', function([_, owner]) {
});

it('should initialize a proxy using scientific notation', async function() {
const proxy = await createProxy({ contractAlias, network, txParams, initMethod: 'initialize', initArgs: ["20e10"], networkFile: this.networkFile });
const proxy = await createProxy({ contractAlias, network, txParams, initMethod: 'initialize', initArgs: [Number("20e10")], networkFile: this.networkFile });
(await proxy.value()).toString().should.be.eq('200000000000');
});

it('should initialize a proxy using large number on scientific notation', async function() {
spalladino marked this conversation as resolved.
Show resolved Hide resolved
const proxy = await createProxy({ contractAlias, network, txParams, initMethod: 'initialize', initArgs: ["20e70"], networkFile: this.networkFile });
(await proxy.value()).toString().should.be.eq('2e+71');
});

describe('warnings', function () {
beforeEach('capturing log output', function () {
this.logs = new CaptureLogs();
Expand Down
Loading