This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Add ESLint and Prettier configs; Apply linting; #920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduce ESLint and Prettier support 🍾
Only
cli
andlib
projects are linted at that moment and warnings are ignored. We have to try this config first and make sure we are comfortable with it. Next steps are:I belive that code consistency is more important than personal preferences yet I want to be absolutely sure that you guys – @spalladino and @jcarpanelli are comfortable with these rules. Let me know if anything feels wrong and we'll figure it out.
PS As @spalladino requested semicolons are in.