Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Add ESLint and Prettier configs; Apply linting; #920

Merged
merged 4 commits into from May 31, 2019

Conversation

ylv-io
Copy link
Contributor

@ylv-io ylv-io commented May 31, 2019

The PR introduce ESLint and Prettier support 🍾

  • Linting is set up on a pre commit hook so it is impossible to commit code without compiling and linting it
  • There are base configs for both ESLint and Prettier
  • Editor extension are available for prettier so a code will be formatted on every save

Only cli and lib projects are linted at that moment and warnings are ignored. We have to try this config first and make sure we are comfortable with it. Next steps are:

  • Linting tests as well
  • Linting other projects
  • Fixing warnings

I belive that code consistency is more important than personal preferences yet I want to be absolutely sure that you guys – @spalladino and @jcarpanelli are comfortable with these rules. Let me know if anything feels wrong and we'll figure it out.

PS As @spalladino requested semicolons are in.

@ylv-io ylv-io added the kind:enhancement Enhancement to an existing feature label May 31, 2019
@ylv-io ylv-io self-assigned this May 31, 2019
Copy link
Contributor

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to blindly approve this one, as I refuse to go through 24k added lines :-P

The config files look good. One change I'd like to see though: can we remove the tslint dependency from the root package.json?

@ylv-io
Copy link
Contributor Author

ylv-io commented May 31, 2019

Absolutely we'll remove it!

@ylv-io ylv-io added the status:ready-to-merge Order mergify to merge label May 31, 2019
@mergify mergify bot merged commit 23bc40b into master May 31, 2019
@mergify mergify bot deleted the feature/eslint-prettier branch May 31, 2019 16:55
ylv-io added a commit that referenced this pull request Jun 1, 2019
* Add ESLint and Prettier configs; Apply linting;

* Fix package.json import issue

* Remove TSLint

* Fix test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:enhancement Enhancement to an existing feature status:ready-to-merge Order mergify to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants