Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing unit tests for the events of the Pausable contract #1180

Closed
come-maiz opened this issue Aug 8, 2018 · 1 comment · Fixed by #1207
Closed

Missing unit tests for the events of the Pausable contract #1180

come-maiz opened this issue Aug 8, 2018 · 1 comment · Fixed by #1207
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Milestone
v2.0

Comments

@come-maiz
Copy link
Contributor

The contract in contracts/lifecycle/Pausable does not have unit tests for the Paused and Unpaused events.
@come-maiz come-maiz added good first issue Low hanging fruit for new contributors to get involved! kind:improvement tests Test suite and helpers. labels Aug 8, 2018
viquezclaudio added a commit to viquezclaudio/openzeppelin-solidity that referenced this issue Aug 13, 2018
@viquezclaudio
Added Event tests to Pausable contract
2e9ad67 
Fixes OpenZeppelin#1180
@viquezclaudio
Copy link
Contributor

I'll work on this issue

@viquezclaudio viquezclaudio mentioned this issue Aug 13, 2018
Merged
2 tasks
@come-maiz come-maiz added this to the v2.0 milestone Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Added Events tests of Pausable contract viquezclaudio/openzeppelin-solidity
2 participants
@come-maiz @viquezclaudio