Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #1606

Merged
merged 7 commits into from
Jan 17, 2019
Merged

Fix warnings #1606

merged 7 commits into from
Jan 17, 2019

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Jan 15, 2019

Part of #1346

With this PR, there is only one warning remaining, which we can't get rid of yet (unless we add a dummy state variable read, but while this may be fine for a mock, I don't think it is for actual production code):

Crowdsale.sol:138:5: Warning: Function state mutability can be restricted to pure
    function _preValidatePurchase(address beneficiary, uint256 weiAmount) internal view {
    ^ (Relevant source part starts here and spans across multiple lines).

It's probably best to review each commit separately.

Regarding the changes:

@nventuro nventuro added improvement contracts Smart contract code. labels Jan 15, 2019
@nventuro nventuro added this to the v2.2 milestone Jan 15, 2019
@nventuro nventuro self-assigned this Jan 15, 2019
@nventuro nventuro requested a review from frangio January 15, 2019 18:26
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nventuro nventuro merged commit b7d60f2 into OpenZeppelin:master Jan 17, 2019
@nventuro nventuro deleted the fix-warnings branch January 17, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants