Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modules load lazily #41

Merged
merged 2 commits into from
May 16, 2019
Merged

Conversation

frangio
Copy link
Contributor

@frangio frangio commented May 14, 2019

This mitigates issues like #40.

@nventuro
Copy link
Contributor

Why is this a draft?

@frangio
Copy link
Contributor Author

frangio commented May 15, 2019

I wanted to think about it a bit more. 🙂

@frangio frangio marked this pull request as ready for review May 15, 2019 15:30
@nventuro
Copy link
Contributor

Why wasn't a CI run triggered? Looks like a bug in GitHub :/

@nventuro nventuro closed this May 15, 2019
@nventuro nventuro reopened this May 15, 2019
@nventuro
Copy link
Contributor

That did it.

@frangio frangio requested a review from nventuro May 16, 2019 14:41
@nventuro nventuro merged commit 91f4022 into OpenZeppelin:master May 16, 2019
@nventuro
Copy link
Contributor

Integration tests passed so I'm happy. Thanks!

@frangio frangio deleted the lazy-modules branch May 16, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants