Disable transpilation of contracts with @custom:stateless in peerProject mode #132
Conversation
|
Not sure about the If we go forward with that format, we should validate the arguments and reject anything that is not That said, I'm not sure I like the annotation name. Is it something we would want to have in the vanilla codebase, or only added in the upgradeable patch? I'm thinking that it will show up in vanilla verified source code otherwise, which is weird. Another option we could consider is |
I'm was thinking that in the future another mode could be used to exclude a contract from the transpilation when |
|
I like |
Amxx
changed the title
| @@ -14,7 +14,7 @@ export function* extractNatspec(node: { | |||
| typeof node.documentation === 'string' ? node.documentation : node.documentation?.text ?? ''; | |||
|
|
|||
| for (const { groups } of execall( | |||
| /^\s*(?:@(?<title>\w+)(?::(?<tag>[a-z][a-z-]*))? )?(?<args>(?:(?!^\s@\w+)[^])*)/m, | |||
| /^\s*(?:@(?<title>\w+)(?::(?<tag>[a-z][a-z-]*))?)?(?: (?<args>(?:(?!^\s@\w+)[^])*))?/m, | |||
There was a problem hiding this comment.
FYI, the issue here is that the space in the tag block prevents parsing title+tag without a space. It is not an issue when there are args, like in @custom:storage-size 50, but it showed up with @custom:stateless not having args.
|
Note: the last refactor removes many of the change from 0.3.28. In particular, exclude is once again a boolean (no more soft exclude). Soft exclusion is implemented by removing file from the Transform object after construction. |
frangio
changed the title
marking a contract as
/// @custom:statelesswill disable the transpilation of a contract when operating in peer project mode. These contracts will be treated as libraries or interfaces.Note that marking a contract as stateless cannot be undone without introducing a breaking change.
Here are some contracts that I believe should be marked as stateless in
@openzeppelin/contracts: