Shock damage effectiveness options #1107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strackeror
force-pushed
the
dev
branch
2 times, most recently
from
2e31400
to
cd33002
Compare
|
Any chance this could be rebased so it can be reviewed? |
|
Yeah, might take a bit, this is pretty old, but I'll take a look at it. |
|
Should be much better up to date now, let me know if anything looks wrong |
|
Cool! I've been hoping we can get something like this in for a while, maybe @Openarl will have some time to review it soon. |
lucifering
added a commit
to lucifering/PathOfBuilding
that referenced
this pull request
Oct 11, 2019
·修改了感电功能 来自：Openarl#1107 —— 勾选感电之后可以出现输入框，可以填入强制感电的伤害加成（这个数值不会再被感电效果加成） —— 使用元素师的【毁灭光炮塔】或【瓦尔·闪电陷阱】时，自带感电伤害承受， 不要在上方的“填入强制感电的伤害输入框”中填写数值，可以被感电效果加成。 —— 暂时不打算处理召唤生物带的感电光环，比如：召唤飞掠者
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some tools so that checking 'Enemy is shocked' can be tuned more precisely.
Adds a 'shocked damage taken modifier' field in the options when 'Enemy is shocked' is checked.
If the field isn't set, it will use scion or elementalist shock nodes as base when allocated. If neither of them are used, we use shock's minimum value of 0.1. This value is then scaled by 'increased effect of shock' and 'non-damaging ailments'.