Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy code from php-cs-fixer #756

Conversation

nlubisch
Copy link
Member

1. Why is this change necessary?

2. What does this change do, exactly?

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

.php_cs Outdated
->in(__DIR__ . '/tests')
->in(__DIR__ . '/dev-ops/local.team-opencaching.de/templates')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls don't remove it

@nlubisch nlubisch force-pushed the feature/php-cs-fixer-remove-legacy-code branch from f245334 to cced921 Compare February 15, 2019 08:45
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #756 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             development    #756   +/-   ##
=============================================
  Coverage           4.99%   4.99%           
  Complexity          2921    2921           
=============================================
  Files                262     262           
  Lines              16965   16965           
=============================================
  Hits                 848     848           
  Misses             16117   16117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e863268...cced921. Read the comment docs.

@teiling88 teiling88 merged commit a23fd3a into OpencachingDeutschland:development Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants