Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose some params for ConnectionQuery #46

Merged
merged 3 commits into from
Apr 8, 2012
Merged

expose some params for ConnectionQuery #46

merged 3 commits into from
Apr 8, 2012

Conversation

benib
Copy link
Contributor

@benib benib commented Apr 7, 2012

  • exposes direct, sleeper, couchette and bike parameter for ConnectionQuery.
  • fixes transportations parameter to default to 'all'

@benib
Copy link
Contributor Author

benib commented Apr 7, 2012

sorry for the commit noise

@fabian fabian merged commit ba221c1 into OpendataCH:master Apr 8, 2012
@fabian
Copy link
Member

fabian commented Apr 8, 2012

Thanks, merged. However I prefer to keep the default for transportations inside the query class.

@dbrgn
Copy link
Contributor

dbrgn commented Apr 10, 2012

Wouldn't it be better if those options would be put coma-separated inside an options parameter?

e.g. &options=sleeper,bike instead of &sleeper=1&bike=1?

@fabian
Copy link
Member

fabian commented Apr 10, 2012

Hmmm, I don't think so… this would required a separate way to parse these options, why not stick to standard URL syntax?

@dbrgn
Copy link
Contributor

dbrgn commented Apr 10, 2012

Ok, agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants