fix(robot-server): ignore trailing empty lines in csv rtps #16185

y3rsh · 2024-09-03T22:29:30Z

Overview

Since it’s commonplace to put an empty line at the end of a file, parse_as_csv() should ignore such lines.

Unit tests cover the scenarios. Will test actual CSV file in bug verification on the next alpha.

Low other than this deviates from how the standard library csv.reader behaves.

api/src/opentrons/protocols/parameters/csv_parameter_interface.py

sfoster1

looks good; if you want to clone rather than modify you can use this example.

api/src/opentrons/protocols/parameters/csv_parameter_interface.py

y3rsh added 3 commits September 3, 2024 17:02

feat(api): parse_as_csv removes trailing empty rows

b629848

fix(test): add test with windows new line sequence

104f41d

fix(test): have full expected result in the test

a8e90e6

y3rsh self-assigned this Sep 3, 2024

y3rsh requested a review from a team as a code owner September 3, 2024 22:29

y3rsh changed the title ~~Rqa 3134 no empty trailing lists~~ RQA-3134 no empty trailing lists Sep 3, 2024

y3rsh added 4 commits September 3, 2024 17:40

fix(test): create function to eleimnat C901 flake8 error

bdd2f40

fix(test): change test description

a941c34

fix(test): fix typo in test description

70d2b49

fix(api): remove a couple comments

7b343eb

y3rsh commented Sep 4, 2024

View reviewed changes

api/src/opentrons/protocols/parameters/csv_parameter_interface.py Show resolved Hide resolved

sfoster1 approved these changes Sep 4, 2024

View reviewed changes

api/src/opentrons/protocols/parameters/csv_parameter_interface.py Show resolved Hide resolved

sfoster1 changed the title ~~RQA-3134 no empty trailing lists~~ fix(robot-server): ignore trailing empty lines in csv rtps Sep 4, 2024

y3rsh merged commit d045115 into chore_release-8.0.0 Sep 4, 2024
21 checks passed

y3rsh deleted the RQA-3134-no-empty-trailing-lists branch September 4, 2024 15:27