chore(api): Add infrastructure for a br2-external tree for buildroot #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More information can be found in https://buildroot.org/downloads/manual/manual.html. This change doesn't alter the normal build infrastructure; it's only used when included by buildroot externally. This tooling provides definitions for our api server and a unit file to bring it up using systemd.
sfoster1
added
feature
Codecov Report
@@ Coverage Diff @@
## edge #3217 +/- ##
==========================================
+ Coverage 53.13% 54.58% +1.44%
==========================================
Files 693 699 +6
Lines 20419 21602 +1183
==========================================
+ Hits 10850 11791 +941
- Misses 9569 9811 +242
Continue to review full report at Codecov.
|
Udev isn’t necessary on the new system.
sfoster1
added
ready for review
and removed
DO NOT MERGE
| @@ -0,0 +1,3 @@ | |||
| # Makefile inclusions for buildroot integration | |||
| include $(BR2_EXTERNAL_OPENTRONS_MONOREPO_PATH)/api/buildroot.mk | |||
| # include $(BR2_EXTERNAL_OPENTRONS_MONOREPO_PATH)/update-server/buildroot.mk | |||
There was a problem hiding this comment.
Is this comment meant to be here?
There was a problem hiding this comment.
I could delete it if you want, it's mostly a memory aid for when we add the update server
There was a problem hiding this comment.
Nope you can keep it in if it's useful for relevant work later on.
|
This is ready for review. It only works in conjunction with Opentrons/buildroot#11, see that PR for more on testing |
mcous
approved these changes
Mar 26, 2019
sfoster1
added a commit
to Opentrons/buildroot
that referenced
this pull request
Mar 26, 2019
- Adds a BR2_EXTERNAL tree from the monorepo (Opentrons/opentrons#3217) and pulls in the opentrons api server to the build. - Fixes some issues in systemd services and targets. Codebuild rewrites broken (and maybe non-broken) absolute links to fit inside its chroot jail, which was breaking the absolute links that aren’t supposed to be valid until they’re on the robot - Add a VERSIONS file taken from a combination of the buildroot version (from git) and opentrons api server versions (from package.json) and save to /etc/VERSIONS.json - VERSIONS.json is a new artifact and also zipped up with the full images and update images when uploaded to s3 Closes Opentrons/opentrons#2877
sfoster1
added a commit
to Opentrons/buildroot
that referenced
this pull request
Mar 26, 2019
- Adds a BR2_EXTERNAL tree from the monorepo (Opentrons/opentrons#3217) and pulls in the opentrons api server to the build. - Fixes some issues in systemd services and targets. Codebuild rewrites broken (and maybe non-broken) absolute links to fit inside its chroot jail, which was breaking the absolute links that aren’t supposed to be valid until they’re on the robot - Add a VERSIONS file taken from a combination of the buildroot version (from git) and opentrons api server versions (from package.json) and save to /etc/VERSIONS.json - VERSIONS.json is a new artifact and also zipped up with the full images and update images when uploaded to s3 Closes Opentrons/opentrons#2877
sfoster1
added a commit
to Opentrons/buildroot
that referenced
this pull request
Jan 4, 2024
- Adds a BR2_EXTERNAL tree from the monorepo (Opentrons/opentrons#3217) and pulls in the opentrons api server to the build. - Fixes some issues in systemd services and targets. Codebuild rewrites broken (and maybe non-broken) absolute links to fit inside its chroot jail, which was breaking the absolute links that aren’t supposed to be valid until they’re on the robot - Add a VERSIONS file taken from a combination of the buildroot version (from git) and opentrons api server versions (from package.json) and save to /etc/VERSIONS.json - VERSIONS.json is a new artifact and also zipped up with the full images and update images when uploaded to s3 Closes Opentrons/opentrons#2877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More information can be found in https://buildroot.org/downloads/manual/manual.html. This change doesn't alter the normal build infrastructure; it's only used when included by buildroot externally.
This tooling provides definitions for our api server and a unit file to bring it up using systemd.
Closes #2877