Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): add CODEOWNERS to repo #4941

Merged
merged 3 commits into from
Feb 7, 2020
Merged

chore(*): add CODEOWNERS to repo #4941

merged 3 commits into from
Feb 7, 2020

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Feb 7, 2020

@sfoster1 sfoster1 added the chore label Feb 7, 2020
@sfoster1 sfoster1 requested a review from a team February 7, 2020 17:27
/protocol-library-kludge @Opentrons/spddrs
/update-server @Opentrons/cpx
/api/src/opentrons @Opentrons/hmg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add discovery-client/cpx here as well?

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 👩‍💻
This is fantastic! Thanks for this.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #4941 into edge will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #4941      +/-   ##
==========================================
+ Coverage   67.76%   67.85%   +0.08%     
==========================================
  Files        1060     1060              
  Lines       35586    35698     +112     
==========================================
+ Hits        24116    24222     +106     
- Misses      11470    11476       +6
Impacted Files Coverage Δ
opentrons/hardware_control/modules/update.py 39.65% <0%> (-9.21%) ⬇️
opentrons/drivers/thermocycler/driver.py 38.36% <0%> (+0.07%) ⬆️
api/tests/opentrons/labware/test_modules.py 97.4% <0%> (+1.3%) ⬆️
opentrons/hardware_control/modules/__init__.py 61.4% <0%> (+1.4%) ⬆️
opentrons/hardware_control/modules/thermocycler.py 91.98% <0%> (+1.93%) ⬆️
opentrons/hardware_control/modules/types.py 90% <0%> (+2.5%) ⬆️
opentrons/hardware_control/modules/magdeck.py 91.42% <0%> (+3.92%) ⬆️
opentrons/hardware_control/modules/tempdeck.py 85.6% <0%> (+5.29%) ⬆️
...i/tests/opentrons/hardware_control/test_modules.py 88.03% <0%> (+15.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1edc587...b1ad83c. Read the comment docs.

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦉

@sfoster1 sfoster1 merged commit 0101ca0 into edge Feb 7, 2020
@sfoster1 sfoster1 deleted the chore_add-codeowners branch February 7, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants