Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Epic) Create a NavBar #17

Closed
kylemh opened this issue Jul 16, 2018 · 16 comments · Fixed by #248
Closed

(Epic) Create a NavBar #17

kylemh opened this issue Jul 16, 2018 · 16 comments · Fixed by #248

Comments

@kylemh
Copy link
Member

kylemh commented Jul 16, 2018

Feature

Why is this feature being added?

  • The live navbar is not very flexible and has a lot of ungraceful style breakage depending on the viewport.
  • We can't list all public content in the nav because it would look very ugly (across 2 or 3 rows)
  • We should be able to list 30+ links within the NavBar without it spanning two bars
    • To accomplish this, we will need a NavItem component that can have a list of other items revealed on hover if needed.
    • See the navbar at https://stripe.com for inspiration

What should your feature do?

  • Create a NavItem common/component that takes a list of links.
    • If it's one link, the NavItem should navigate onClick and onEnterDown.
    • If it's multiple links, the NavItem should show/hide the NavItemDropdown on/off hover and on/off click.
    • On mobile, the all links in NavItem should render in a visual grouping (no using NavItemDropdown).
  • Create a NavItemDropdown common/component.
  • Use the above components to create a responsive, kick-ass NavBar and implement it.
  • Create stories for each component comparable to the Button's story in quality and depth.
  • Write unit tests for each component.
  • Generate snapshots for each component.

Desktop Mock

screen shot 2018-10-21 at 10 18 06 pm

Mobile Mock

(For screen sizes under 769px in width)
Note: You've got creative freedom for what appears after clicking MENU+, but it should contain every link that the navbar does.
Note 2: Please put the plus to the left of MENU to be consistent with the rest of the nav
screen shot 2018-10-21 at 10 26 27 pm

@kylemh kylemh added the Status: Blocked At this moment, the completion of this ticket is impossible label Jul 16, 2018
@kylemh kylemh changed the title Create a NavBar (Epic) Create a NavBar Jul 16, 2018
@kylemh kylemh removed the Status: Blocked At this moment, the completion of this ticket is impossible label Jul 29, 2018
@jjhampton jjhampton self-assigned this Aug 17, 2018
@chrismgonzalez
Copy link
Contributor

Is anyone currently working on this? It would be great to have it up and working by Hacktoberfest.

@kylemh
Copy link
Member Author

kylemh commented Sep 22, 2018

It’s assigned to @jjhampton

@jjhampton
Copy link
Member

sorry, i've been lagging on this. i hope to get some work in tonight. @chrismgonzalez @kylemh

@kylemh
Copy link
Member Author

kylemh commented Oct 1, 2018

Note: https://invis.io/NTO3FK69UQS for redesign

@zacharyrgonzales
Copy link

I would love to work this! I just got finished the ui for a website with css grid. Can I be assigned to this and or work on this feature?

@kylemh
Copy link
Member Author

kylemh commented Oct 2, 2018

Hey @zacharyrgonzales - we appreciate your interest. This issue has a lot of secret context and it’s been assigned to a staff member of Operation Code. There are still plenty of other issues available!

@zacharyrgonzales
Copy link

zacharyrgonzales commented Oct 2, 2018 via email

@kylemh
Copy link
Member Author

kylemh commented Oct 13, 2018

Unassigning this as @jjhampton is unavailable.

@zacharyrgonzales
Copy link

zacharyrgonzales commented Oct 14, 2018 via email

@zacharyrgonzales
Copy link

zacharyrgonzales commented Oct 14, 2018 via email

@kylemh
Copy link
Member Author

kylemh commented Oct 14, 2018

I think you can accomplish this without Grid and hope you try using flexbox instead! I feel like it's easy for us to support IE11 and want to move to support it at some point in the future - Grid would make that a bit more difficult.

I am assigning myself to this issue as a placeholder for your work. Thank you, and good luck! 😁

Please note:
If no activity is shared within two weeks, I will remove my assignment. At that point, the issue will be open for anybody to take.

@kylemh kylemh self-assigned this Oct 14, 2018
@zacharyrgonzales
Copy link

zacharyrgonzales commented Oct 14, 2018 via email

@zacharyrgonzales
Copy link

zacharyrgonzales commented Oct 14, 2018 via email

@kylemh
Copy link
Member Author

kylemh commented Oct 14, 2018

@zacharyrgonzales no worries.

@RaevLogic you're up!

@jeffnhorner
Copy link

Would love to take a stab at this if @RaevLogic passes or decides not to work on it.

@kylemh
Copy link
Member Author

kylemh commented Oct 17, 2018

@jhorner32 I do believe @RaevLogic is working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants