Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

317 stow mobile nav #321

Merged
merged 23 commits into from Jan 13, 2019
Merged

317 stow mobile nav #321

merged 23 commits into from Jan 13, 2019

Conversation

jmayergit
Copy link
Contributor

Description of changes

The dropdown of Nav Mobile component will disappear, as it should, when navigating between pages

Issue Resolved

Fixes #317

Screenshots/GIFs

@vercel
Copy link

vercel bot commented Dec 21, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@kylemh
Copy link
Member

kylemh commented Dec 21, 2018

🤖 This is a bot 🤖

🎉 Deployed Storybook preview! 🎉

Click the link at the bottom of this comment to see it live.

Built with commit c14f06b

https://deploy-preview-321--operation-code-storybook.netlify.com

@kylemh
Copy link
Member

kylemh commented Dec 21, 2018

🤔 it looks the hamburger button isn't visible on /events page

@jmayergit
Copy link
Contributor Author

Is that still the case?

@kylemh
Copy link
Member

kylemh commented Dec 22, 2018

Nah, but now it's happening on /branding

@jmayergit
Copy link
Contributor Author

I don't know what would be causing it. Steps to reproduce?

Also was it this way before I wonder

@kylemh
Copy link
Member

kylemh commented Dec 22, 2018

It may have been... Only STR I can provide to load the preview and navigate to a bunch of routes... seems like once and awhile hamburger goes off screen.

@kylemh
Copy link
Member

kylemh commented Dec 26, 2018

@jmayergit none of it was your issue! I found a few spots that broke the app's view and committed them here.

jest.setup.js Outdated
route: '/mock-route',
withRouter: Component => Component,
}));
// Next Router (mocking this isn't inherently useful)
Copy link
Member

@kylemh kylemh Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and delete the block instead of commenting out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@jmayergit
Copy link
Contributor Author

How's it lookin?

Copy link
Member

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very happy with this 👍

@kylemh kylemh merged commit 50d170e into master Jan 13, 2019
@kylemh kylemh deleted the 317-stow-mobile-nav branch January 13, 2019 13:30
@jmayergit
Copy link
Contributor Author

Thank you, it was good to learn about Next.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stow dropdown on mobile nav if route changes
2 participants