New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
317 stow mobile nav #321
317 stow mobile nav #321
Conversation
This pull request is automatically deployed with Now. |
🤖 This is a bot 🤖 Built with commit c14f06b https://deploy-preview-321--operation-code-storybook.netlify.com |
🤔 it looks the hamburger button isn't visible on /events page |
Is that still the case? |
Nah, but now it's happening on /branding |
I don't know what would be causing it. Steps to reproduce? Also was it this way before I wonder |
It may have been... Only STR I can provide to load the preview and navigate to a bunch of routes... seems like once and awhile hamburger goes off screen. |
@jmayergit none of it was your issue! I found a few spots that broke the app's view and committed them here. |
…e/front-end into 317-stow-mobile-nav
jest.setup.js
Outdated
route: '/mock-route', | ||
withRouter: Component => Component, | ||
})); | ||
// Next Router (mocking this isn't inherently useful) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and delete the block instead of commenting out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k
How's it lookin? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very happy with this 👍
Thank you, it was good to learn about Next.js |
Description of changes
The dropdown of Nav Mobile component will disappear, as it should, when navigating between pages
Issue Resolved
Fixes #317
Screenshots/GIFs