-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress Visual Regression Test Adjustments #492
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://operation-code-git-make-cypress-snaps-consistent.operation-code.now.sh |
🤖 This is a bot 🤖 Built with commit a298d6a https://deploy-preview-492--operation-code-storybook.netlify.com |
So, we could bump variance up to 3% to account for Code Schools, with our API GET request to the code_schools endpoint I'm gonna focus on duct-taping this and fix the issues later, as I should really be focusing on finishing registration + profile editing. Lastly, I couldn’t quite get mobile + desktop visual regression tests to work in conjunction. It seemed as though the viewport change is asynchronous… I wonder if it’d be better instead to create two functions (1 for desktop and 1 for mobile) and put them in two different test names :thinking_face: |
…-cypress-snaps-consistent
Working on resolving the build failures in jaredpalmer/cypress-image-snapshot#82 |
…-cypress-snaps-consistent
…ode/front-end into make-cypress-snaps-consistent
In the end, no matter what I did, I encountered either OR an issue where my screenshot would be 1px different between builds. Linking helpful issues for posterity: |
Description of changes
describe
.gitignore
On Hold
We're going to add Docker to the equation so that testing headlessly is the same between CI and local environments. That should remove the variability between fullPage screenshots I'm seeing. On top of that, this PR would lead to much larger build times, so I'm going to put it on hold for #449 as well.
See comments below for more context.